commitlog: Make offset index usable externally #2108
Merged
+138
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim
force-pushed
the
kim/commitlog/external-offset-index
branch
2 times, most recently
from
8fd6f6d to
9548f23
Compare
* make `OffsetIndexWriter::append_after_commit` pub * expose offset index len calculation as method on `Options` * add conversions between mutable and read-only index (`as_mut`, `From` impls) * add an iterator, which may be used to check if the index is valid
kim
force-pushed
the
kim/commitlog/external-offset-index
branch
from
9548f23 to
2d8a98e
Compare
Shubham8287
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OffsetIndexWriter::append_after_commitpubOptionsas_mut,Fromimpls)Expected complexity level and risk
1
Testing
Added a test for the iterator. The other changes are just visibility.